diff --git a/addons/acodec/ogg.c b/addons/acodec/ogg.c index 0db1545..915e1f6 100644 --- a/addons/acodec/ogg.c +++ b/addons/acodec/ogg.c @@ -419,8 +419,9 @@ static size_t ogg_stream_update(ALLEGRO_AUDIO_STREAM *stream, void *data, /* If nothing read then now to silence from here to the end. */ if (read == 0) { - int silence = _al_kcm_get_silence(stream->spl.spl_data.depth); - memset((char *)data + pos, silence, buf_size - pos); + unsigned long silence_samples=(buf_size - pos)/ + (al_get_audio_depth_size(stream->spl.spl_data.depth)*al_get_channel_count(stream->spl.spl_data.chan_conf)); + al_fill_silence((char*)data + pos, silence_samples, stream->spl.spl_data.depth, stream->spl.spl_data.chan_conf); /* return the number of usefull byes written */ return pos; } diff --git a/addons/audio/allegro5/allegro_audio.h b/addons/audio/allegro5/allegro_audio.h index 2fd9a82..51cd4a2 100644 --- a/addons/audio/allegro5/allegro_audio.h +++ b/addons/audio/allegro5/allegro_audio.h @@ -339,6 +339,8 @@ ALLEGRO_KCM_AUDIO_FUNC(uint32_t, al_get_allegro_audio_version, (void)); ALLEGRO_KCM_AUDIO_FUNC(size_t, al_get_channel_count, (ALLEGRO_CHANNEL_CONF conf)); ALLEGRO_KCM_AUDIO_FUNC(size_t, al_get_audio_depth_size, (ALLEGRO_AUDIO_DEPTH conf)); +ALLEGRO_KCM_AUDIO_FUNC(void, al_fill_silence, (void * buf, unsigned int samples, ALLEGRO_AUDIO_DEPTH depth, ALLEGRO_CHANNEL_CONF chan_conf)); + /* Simple audio layer */ ALLEGRO_KCM_AUDIO_FUNC(bool, al_reserve_samples, (int reserve_samples)); ALLEGRO_KCM_AUDIO_FUNC(ALLEGRO_MIXER *, al_get_default_mixer, (void)); diff --git a/addons/audio/allegro5/internal/aintern_audio.h b/addons/audio/allegro5/internal/aintern_audio.h index cf6f899..eda0859 100644 --- a/addons/audio/allegro5/internal/aintern_audio.h +++ b/addons/audio/allegro5/internal/aintern_audio.h @@ -308,7 +308,6 @@ typedef enum { extern void _al_set_error(int error, char* string); /* Supposedly internal */ -ALLEGRO_KCM_AUDIO_FUNC(int, _al_kcm_get_silence, (ALLEGRO_AUDIO_DEPTH depth)); ALLEGRO_KCM_AUDIO_FUNC(void*, _al_kcm_feed_stream, (ALLEGRO_THREAD *self, void *vstream)); /* Helper to emit an event that the stream has got a buffer ready to be refilled. */ diff --git a/addons/audio/alsa.c b/addons/audio/alsa.c index 08615cf..72e605c 100644 --- a/addons/audio/alsa.c +++ b/addons/audio/alsa.c @@ -349,8 +349,7 @@ static void *alsa_update_mmap(ALLEGRO_THREAD *self, void *arg) int silence; silence: /* If stopped just fill with silence. */ - silence = _al_kcm_get_silence(voice->depth); - memset(mmap, silence, frames * alsa_voice->frame_size); + al_fill_silence(mmap, frames, voice->depth, voice->chan_conf); } snd_pcm_sframes_t commitres = snd_pcm_mmap_commit(alsa_voice->pcm_handle, offset, frames); @@ -449,16 +448,16 @@ static void *alsa_update_rw(ALLEGRO_THREAD *self, void *arg) /* This should fit. */ unsigned int iframes = frames; buf = (void *)_al_voice_update(voice, &iframes); - frames = iframes; if (buf == NULL) goto silence; + + frames = iframes; } else { int silence; silence: /* If stopped just fill with silence. */ - silence = _al_kcm_get_silence(voice->depth); - memset(data, silence, bytes); + al_fill_silence(data, frames, voice->depth, voice->chan_conf); buf = data; } err = snd_pcm_writei(alsa_voice->pcm_handle, buf, frames); diff --git a/addons/audio/audio.c b/addons/audio/audio.c index 6f593f9..c8ee127 100644 --- a/addons/audio/audio.c +++ b/addons/audio/audio.c @@ -119,18 +119,66 @@ ALLEGRO_AUDIO_DEPTH _al_word_size_to_depth_conf(int word_size) } } -/* Returns a silent sample frame. */ -int _al_kcm_get_silence(ALLEGRO_AUDIO_DEPTH depth) +void al_fill_silence(void * buf, unsigned int samples, ALLEGRO_AUDIO_DEPTH depth, ALLEGRO_CHANNEL_CONF chan_conf) { - switch (depth) { - case ALLEGRO_AUDIO_DEPTH_UINT8: - return 0x80; - case ALLEGRO_AUDIO_DEPTH_INT16: - return 0x8000; - case ALLEGRO_AUDIO_DEPTH_INT24: - return 0x800000; - default: - return 0; + size_t buffersize=al_get_audio_depth_size(depth)*al_get_channel_count(chan_conf)*samples; + + switch(depth) + { + case ALLEGRO_AUDIO_DEPTH_INT8: + case ALLEGRO_AUDIO_DEPTH_INT16: + case ALLEGRO_AUDIO_DEPTH_INT24: + case ALLEGRO_AUDIO_DEPTH_FLOAT32: + memset(buf, 0, buffersize); + break; + case ALLEGRO_AUDIO_DEPTH_UINT8: + memset(buf, 128, buffersize); + break; +#ifdef ALLEGRO_BIG_ENDIAN + case ALLEGRO_AUDIO_DEPTH_UINT16: + { + size_t i=0; + unsigned char * buffer=(unsigned char*)buf; + while(idepth); - memset(silence, silence_value, buffer_size); + al_fill_silence(silence, buffer_size_in_samples, voice->depth, voice->chan_conf); /* Fill buffer */ hr = ex_data->ds8_buffer->Lock(0, buffer_size, diff --git a/addons/audio/kcm_stream.c b/addons/audio/kcm_stream.c index c2835fc..205a5f6 100644 --- a/addons/audio/kcm_stream.c +++ b/addons/audio/kcm_stream.c @@ -121,10 +121,10 @@ ALLEGRO_AUDIO_STREAM *al_create_audio_stream(size_t fragment_count, } for (i = 0; i < fragment_count; i++) { - stream->used_bufs[i] = - (char *) stream->main_buffer - + i * (MAX_LAG*bytes_per_sample + bytes_per_frag_buf) - + MAX_LAG*bytes_per_sample; + char*buffer=(char *) stream->main_buffer + + i * (MAX_LAG*bytes_per_sample + bytes_per_frag_buf); + al_fill_silence(buffer, MAX_LAG, depth, chan_conf); + stream->used_bufs[i] = buffer + MAX_LAG*bytes_per_sample; } al_init_user_event_source(&stream->spl.es); @@ -478,8 +478,7 @@ static void reset_stopped_stream(ALLEGRO_AUDIO_STREAM *stream) * user should be OK. */ for (i = 0; i < stream->buf_count; ++i) { - memset((char *)stream->main_buffer + i * fragment_buffer_size, 0, - MAX_LAG * bytes_per_sample); + al_fill_silence((char*)stream->main_buffer + i * fragment_buffer_size, MAX_LAG, stream->spl.spl_data.depth, stream->spl.spl_data.chan_conf); } /* Get the current number of entries in the used_buf list. */ diff --git a/addons/audio/oss.c b/addons/audio/oss.c index 986429e..b355679 100644 --- a/addons/audio/oss.c +++ b/addons/audio/oss.c @@ -76,7 +76,6 @@ static int oss_fragsize = (8 << 16) | (10); /* Auxiliary buffer used to store silence. */ #define SIL_BUF_SIZE 1024 -static char sil_buf[SIL_BUF_SIZE]; static bool using_ver_4; @@ -465,7 +464,9 @@ static void* oss_update(ALLEGRO_THREAD *self, void *arg) else { silence: /* If stopped just fill with silence. */ - memset(sil_buf, _al_kcm_get_silence(voice->depth), SIL_BUF_SIZE); + char sil_buf[SIL_BUF_SIZE]; + const unsigned int silent_samples=SIL_BUF_SIZE/(al_get_audio_depth_size(voice->depth)*al_get_channel_count(voice->chan_conf)); + al_fill_silence(sil_buf, silent_samples, voice->depth, voice->chan_conf); if (write(oss_voice->fd, sil_buf, SIL_BUF_SIZE) == -1) { ALLEGRO_ERROR("errno: %i -- %s\n", errno, strerror(errno)); }